chore: Updating examples for CARLA and driving domain#257
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 86.16% 86.23% +0.06%
==========================================
Files 144 144
Lines 25007 25124 +117
==========================================
+ Hits 21547 21665 +118
+ Misses 3460 3459 -1 ☔ View full report in Codecov by Sentry. |
lola831
approved these changes
Dec 18, 2024
Collaborator
lola831
left a comment
There was a problem hiding this comment.
I tested the updated instructions in CARLA, and everything worked as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
*.scenicexample files for the CARLA and driving domain manual control from strings to integersIssue Link
As a result of testing and implementing these changes, two issues were open:
#255
#256
This PR intends to workaround the issues rather than provide a direct fix.
Checklist
pytestand/or other meansAdditional Notes