Conversation
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 91.37% 91.37% -0.01%
==========================================
Files 54 54
Lines 13544 13555 +11
==========================================
+ Hits 12376 12386 +10
- Misses 1168 1169 +1
|
dfremont
reviewed
Oct 28, 2024
dfremont
reviewed
Oct 28, 2024
dfremont
requested changes
Oct 28, 2024
Collaborator
dfremont
left a comment
There was a problem hiding this comment.
Looks great, just one tiny fix and a question.
dfremont
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several issues with the Newtonian simulator:
debugRenderthat always draws polygons to help verify that cars (or any future objects) are being drawn correctly.Issue Link
This will resolve Issue #304.
Checklist
pytestand/or other meansAdditional Notes
To verify that this resolves Issue #304, run an example Scenic program with the
debugRendererparameter set toTrue. An example is included below:scenic examples/driving/badlyParkedCarPullingIn.scenic --2d --simulate --model scenic.simulators.newtonian.driving_model --time 200 --count 1 -p debugRender TrueI've also included several screenshots showing the correct behavior which is now present:

