Skip to content

Fix: Use shapely.points instead of shapely.lib.points for point creation#336

Merged
dfremont merged 1 commit intoBerkeleyLearnVerify:mainfrom
lola831:fix/shapely
Apr 7, 2025
Merged

Fix: Use shapely.points instead of shapely.lib.points for point creation#336
dfremont merged 1 commit intoBerkeleyLearnVerify:mainfrom
lola831:fix/shapely

Conversation

@lola831
Copy link
Copy Markdown
Collaborator

@lola831 lola831 commented Apr 4, 2025

Description

This commit replaces the internal call to shapely.lib.points with the public API shapely.points. Our code worked with Shapely 2.0.7, but with the release of 2.1.0 the internal method no longer accepts our inputs correctly, causing errors during point creation. This fix resolves those errors by using the officially supported method.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont April 4, 2025 17:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (5d36cce) to head (4b59e60).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   91.38%   91.35%   -0.03%     
==========================================
  Files          54       54              
  Lines       13579    13584       +5     
==========================================
+ Hits        12409    12410       +1     
- Misses       1170     1174       +4     
Files with missing lines Coverage Δ
src/scenic/core/geometry.py 94.89% <100.00%> (-1.28%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfremont dfremont merged commit b72430c into BerkeleyLearnVerify:main Apr 7, 2025
31 checks passed
@dfremont dfremont linked an issue Apr 7, 2025 that may be closed by this pull request
3 tasks
@dfremont dfremont mentioned this pull request May 27, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any example I try to run, I get the same TypeError

2 participants