Add Fix for the Size-based containsRegion Heuristic#458
Merged
Conversation
containsRegion Heuristic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 89.64% 89.71% +0.06%
==========================================
Files 48 48
Lines 13226 13226
==========================================
+ Hits 11857 11866 +9
+ Misses 1369 1360 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the size-based fast path used in
containsRegion. It previously triggered when tolerance is non-zero (but ignored tolerance) and was susceptible to small numerical errors. This fix disables it for cases with non-zero tolerance and adds a small fudge-factor to ensure the heuristic is robust to small numerical errors.Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes
N/A