hotfix: zeitwerk autoloading error for av_player/track_extensions #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarchivist
force-pushed
the
zeitwerk-hotfix
branch
from
0ac2b3a to
e144694
Compare
Excludes lib/av_player from autoloading as it doesn't follow the paradigm that Zeitwerk expects for autoloading (it extends BerkeleyLibrary::AV::Track, and there is not a corresponding AvPlayer::TrackExtensions)
anarchivist
force-pushed
the
zeitwerk-hotfix
branch
from
e144694 to
fdf2797
Compare
awilfox
approved these changes
Dec 5, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Nice find. Looks good to me. r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes
lib/av_playerfrom autoloading as it doesn't follow the paradigm that Zeitwerk expects for autoloading (it extendsBerkeleyLibrary::AV::Track, and there is not a correspondingAvPlayer::TrackExtensions)