user: Use either capitalisation for email attr#23
Merged
Conversation
awilfox
requested review from
anarchivist,
davezuckerman,
jason-raitz and
yzhoubk
It looks like CalNet may be sending *either* capitalisation for the email attribute, as sometimes users have emails set and other times they don't (even the same user). Ref: AP-583
awilfox
force-pushed
the
awilfox/AP-583-email-attr
branch
from
1629ff9 to
168a538
Compare
Member
Author
|
v2: Appease Rubocop (disable |
anarchivist
approved these changes
Feb 18, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+. thanks for digging into this!
yzhoubk
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like CalNet may be sending either capitalisation for the email attribute, as sometimes users have emails set and other times they don't (even the same user).
Ref: AP-583
Note that I don't have any confirmation of this, because we aren't logging CalNet responses. But considering "sometimes" we get email addresses and "sometimes" we don't, and we had the same "sometimes" before the capitalisation change I made, this is the logical next step towards debugging this issue.