Check yarn version and enable corepack#14
Merged
anarchivist merged 2 commits intomainfrom Aug 14, 2025
Merged
Conversation
Without this, we cannot guarantee that we will build galc-ui with the correct version of Yarn. GitHub Actions Ubuntu images ship with [Yarn 1.22.22 by default][0]. [0]: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
yzhoubk
approved these changes
Aug 13, 2025
awilfox
approved these changes
Aug 14, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks good. Left a single minor suggestion regarding future-proofing of the shell script. r+ after that.
Contributor
|
looks good. @anarchivist, While we're messing with this build, could we maybe alter the condition for publishing the snapshot? maybe change galc-ui/.github/workflows/build.yml Line 62 in 83a67ef to if: (github.ref_name == 'main' && github.event_name == 'push') || github.event_name == 'workflow_dispatch'That would allow a user to manually publish the snapshot on any branch. Could be useful for reviewing changes in staging. |
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Member
Author
|
@jason-raitz that's a good idea, but i don't think we should do it until automatic snapshot publishing is working. we can certainly revisit it in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we cannot guarantee that we will build galc-ui with the correct version of Yarn. GitHub Actions Ubuntu images ship with Yarn 1.22.22 by default.