Closed
Conversation
The wasm-node version of Rollup is portable to any Node platform, so it does not have per-CPU and per-OS native builds. By using this as our implementation of Rollup, we avoid having to add each platform/OS we want to run Geodata on. (We can also now run on places Rollup doesn't.) Closes: AP-344
Contributor
|
Replaced Rollup with the wasm-node 4.27.4 override, it works well locally. |
Member
Author
|
Rebased and merged as 8dd07a7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm-node version of Rollup is portable to any Node platform, so it does not have per-CPU and per-OS native builds. By using this as our implementation of Rollup, we avoid having to add each platform/OS we want to run Geodata on. (We can also now run on places Rollup doesn't.)
Closes: AP-344
--
Note: I vendored wasm-node 4.27.4 instead of 4.27.3 to work around an npm bug where it won't do an override when the version is an exact match. Everything appears to work fine, and tests still pass, so I think it is still fully compatible.