Merged
Conversation
Contributor
jason-raitz
commented
Aug 6, 2025
jason-raitz
commented
- adds new etl utility doc-processing
- tests for doc_proc
- adds .DS_Store to .gitignore
- updates pyproject.toml
- updates readme with local testing and linting instructions
jason-raitz
commented
Aug 6, 2025
awilfox
reviewed
Aug 6, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks good overall. There's a few nitpicks and a small improvement.
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
awilfox
approved these changes
Aug 6, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Needs two lines between methods in willa/etl/doc_proc.py then ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.