Docker: Use single target app for deployment#73
Merged
Conversation
awilfox
requested review from
anarchivist,
danschmidt5189,
davezuckerman and
jason-raitz
awilfox
force-pushed
the
awilfox/AP-469-docker-targets
branch
from
b1ca06d to
e441aa7
Compare
This removes the ``development`` target which we were using to contain our extra development dependencies, combining it into the ``app`` target. Note that this adds an additional ~300 MB to the image size right now; this will be addressed by AP-470. Implements: AP-469
awilfox
force-pushed
the
awilfox/AP-469-docker-targets
branch
from
e441aa7 to
6dd2e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
developmenttarget which we were using to contain our extra development dependencies, combining it into theapptarget.Note that this adds an additional ~300 MB to the image size right now; this will be addressed by AP-470.
Implements: AP-469