Use AsyncRetry in acompletion_with_retries#9262
Closed
swiftdevil wants to merge 3 commits intoBerriAI:mainfrom
Closed
Use AsyncRetry in acompletion_with_retries#9262swiftdevil wants to merge 3 commits intoBerriAI:mainfrom
swiftdevil wants to merge 3 commits intoBerriAI:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
This PR fixes the retry mechanism in
main.acompletion_with_retries. Although this method is deprecated, it is used in theutils.client.wrapper_asyncmethod, which is not marked as deprecated - meaning this should be fixed, orutils.client.wrapper_asyncshould be updated to usemain.acompletionorrouter.acompletion.Relevant issues
Similar to #4908 however updating
utils.client.wrapper_asyncto usemain.acompletioncauses unexpected results.Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Type
🐛 Bug Fix
Changes