Skip to content

Modify plugin arguments in pom.xml #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasturrell merged 2 commits into from
Nov 16, 2025
Merged

Modify plugin arguments in pom.xml #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b13a4
Modify plugin arguments in pom.xml
thomasturrell Nov 16, 2025
6dace77
Update Maven publish command to include dependencies
thomasturrell Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven-publish-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
server-password: MAVEN_PASSWORD

- name: Publish snapshot package
run: mvn -B deploy --file pom.xml -pl xapi-build,xapi-model,xapi-client,xapi-model-spring-boot-starter
run: mvn -B deploy --file pom.xml -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing xapi-build from the -pl argument may cause issues for consumers. The child modules (xapi-model, xapi-client, xapi-model-spring-boot-starter) reference xapi-build as their parent in their POMs. When these artifacts are published to the snapshot repository, they will contain this parent reference, which means Maven needs to be able to resolve the xapi-build POM.

With this change, only the three explicitly listed modules will be deployed, not the parent POM. This could result in "Could not find artifact dev.learning.xapi:xapi-build:pom:version" errors for consumers of snapshot versions.

The -am (also-make) flag ensures that dependencies are built before the specified modules, but it does not affect which modules are deployed - only modules in the -pl list are deployed.

Consider whether the parent POM should remain in the deployment list, or if there's another mechanism to ensure it's published to the snapshot repository.

Suggested change
run: mvn -B deploy --file pom.xml -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am
run: mvn -B deploy --file pom.xml -pl xapi-build,xapi-model,xapi-client,xapi-model-spring-boot-starter -am

Copilot uses AI. Check for mistakes.
env:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
<releaseProfiles>release</releaseProfiles>
<goals>deploy</goals>
<!-- Only release production modules, exclude all sample modules -->
<arguments>-pl xapi-build,xapi-model,xapi-client,xapi-model-spring-boot-starter</arguments>
<arguments>-pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am</arguments>
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing xapi-build from the -pl argument may cause issues for consumers. The child modules (xapi-model, xapi-client, xapi-model-spring-boot-starter) reference xapi-build as their parent in their POMs. When these artifacts are published to Maven Central, they will contain this parent reference, which means Maven needs to be able to resolve the xapi-build POM.

With this change, only the three explicitly listed modules will be deployed, not the parent POM. This could result in "Could not find artifact dev.learning.xapi:xapi-build:pom:version" errors for consumers.

The -am (also-make) flag ensures that dependencies are built before the specified modules, but it does not affect which modules are deployed - only modules in the -pl list are deployed.

Consider whether the parent POM should remain in the deployment list, or if there's another mechanism to ensure it's published to Maven Central.

Copilot uses AI. Check for mistakes.
</configuration>
</plugin>
</plugins>
Expand Down
Loading