Skip to content

fix(references): don't rewrite references if the arrays are equal despite order differences#15

Merged
Bessonov merged 1 commit intoBessonov:masterfrom
scamden:master
Nov 16, 2022
Merged

fix(references): don't rewrite references if the arrays are equal despite order differences#15
Bessonov merged 1 commit intoBessonov:masterfrom
scamden:master

Conversation

@scamden
Copy link
Copy Markdown
Collaborator

@scamden scamden commented Nov 16, 2022

Hi again @Bessonov! We are running into a problem where set-project-references is rewriting our file every time and i realized it's because the order of the tsconfig refs can be different from the workspaces deps. It's idempotent so this isn't usually a big deal but the writing of the tsconfig.json also removes the newline we have at the end of our file due to prettier. This causes the build to fail when we check the prettier format later.

This change causes the tool to do less work and not rewrite when the config is already up to date anyway. I would like to make another pr for adding a newline at the end of the file potentially. Let me know if you're open to that and I'll write it.

Hope you're well!

@scamden
Copy link
Copy Markdown
Collaborator Author

scamden commented Nov 16, 2022

on a side note, i'd love to be made a maintainer on this if you're willing. no pressure but would make these changes a little quicker and hopefully I've shown i care about the package :)

@scamden
Copy link
Copy Markdown
Collaborator Author

scamden commented Nov 16, 2022

@Bessonov ping cause i worry the edit didn't do it :)

@Bessonov
Copy link
Copy Markdown
Owner

@scamden first of all, thank you very much for your contribution!

I would like to make another pr for adding a newline at the end of the file potentially. Let me know if you're open to that and I'll write it.

Yes, I'm open to it.

on a side note, i'd love to be made a maintainer on this if you're willing.

Never did it at GH, I will try :)

P.S. I was interested in this too: Adding mention afterwards worked as expected - I was notified.

@Bessonov Bessonov merged commit 2a9906e into Bessonov:master Nov 16, 2022
@scamden
Copy link
Copy Markdown
Collaborator Author

scamden commented Nov 16, 2022

P.S. I was interested in this too: Adding mention afterwards worked as expected - I was notified.

oh great! haha now i know thanks!

@scamden
Copy link
Copy Markdown
Collaborator Author

scamden commented Nov 16, 2022

i got the access thank you! i think you may still have to publish though. you could add me to the npm project if you want to allow it as well i think. up to you! thanks again!

@Bessonov
Copy link
Copy Markdown
Owner

you may still have to publish though

Yes, I will try it after your next PR. I didn't it for a while...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants