Normalize the address for VaultConfig for consistent pathing downstream.#132
Merged
steve-perkins merged 1 commit intoBetterCloud:masterfrom Jun 4, 2019
Merged
Conversation
Contributor
|
Thanks, @BrianDeacon! |
rimitchell
pushed a commit
to rimitchell/vault-java-driver
that referenced
this pull request
Jul 22, 2019
Normalize the address for VaultConfig for consistent pathing downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a by-product of chasing down a bug having to do with tokens. I had configured my testing to point to "https://localhost:8200/" (with trailing slash). This was causing a POST request to "https://localhost:8200//v1/transit/keys/my-key" (note the extra slash) to receive a 302 to "https://localhost:8200/v1/transit/keys/my-key" (slash removed).
My problem went away just by changing my configuration to not contain the trailing slash, but the underlying cause is deep in the bowels of HttpUrlConnection, which isn't propagating the X-Vault-Token header when it redirects, and then getting an error message about missing token returned in a 400 from Vault.