added license key to telemetry_ping events. Refactored util method location#118
Merged
added license key to telemetry_ping events. Refactored util method location#118
Conversation
jamby77
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds license-derived identifier data to recurring
telemetry_pingevents; while truncated, it still affects telemetry payloads and potential privacy expectations. Risk is moderate because it changes analytics event schemas used in production.Overview
Adds a truncated license-key suffix to telemetry heartbeats.
LicenseService.sendHeartbeat()now attacheslicenseKey(last 4 chars only) to thetelemetry_pingevent properties for correlation.Refactors license-key truncation logic into
LicenseService.UsageTelemetryService.getLicenseKeySafely()now delegates to a newLicenseService.getTruncatedLicenseKey()helper instead of inlining license key access/truncation.Reviewed by Cursor Bugbot for commit be942ae. Bugbot is set up for automated code reviews on this repo. Configure here.