Make code more compatible with typedoc#2178
Draft
TheLazySquid wants to merge 49 commits into
Draft
Conversation
Not very happy with some of this
Also deleted FormattableString since it's completely unused
For the record this was broken before I did anything
Sure I guess
Also remove warning jsdoc tag
There was a problem hiding this comment.
Code Review
This pull request performs a major TypeScript migration and refactoring of the BetterDiscord API, introducing 'Bound' class variants for plugin-scoped instances and a new build process for bundled type declarations. The changes involve extensive type annotations across core modules, stores, and UI components. Feedback identifies a potential runtime error in the context menu builder due to a missing label check and critiques a risky pattern in the BdApi class where prototype getters return unbound instances despite being typed as bound ones.
Member
|
Converted to draft since it is awaiting a prerequisite PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is on top of #2134, and changes BD's code to be friendlier to typedoc for this docs PR. Changes include:
@ignored constructors