Interferes with Capybara tests even when only added to dev group

[mcmire]

Hey there -- it doesn't seem that this issue has been raised yet, and I don't even know if this issue is necessarily the fault of this gem, but I'm opening this in the hopes that I can get some pointers.

It seems that adding better_errors is interfering with Capybara feature tests, even when it's added only to the development group.

Here's what I did:

• Made a simple vanilla Rails app (4.2.1)

• Added rspec-rails (3.2.1)

• Ran rails g rspec:install

• Added the following to config/routes.rb: get /users, to: "users#index"

• Added the following test to spec/features/my_feature_spec.rb

  require 'rails_helper'
  
  feature 'My feature' do
    scenario 'is awesome' do
      visit '/users'
      expect(page).to have_content('Users')
    end
  end

• Ran the test. As expected, it fails with: ActionController::RoutingError: uninitialized constant UsersController

• Then, I added better_errors to the Gemfile, but only in the development group

• Ran the test again. Now it passes! How? Well, if you throw in a save_and_open_page then you'll get the text version of better_errors:

  ActionController::RoutingError at /users
  ========================================
  
  > uninitialized constant UsersController
  
  spec/features/my_feature_spec.rb, line 5
  ----------------------------------------
  
  ``` ruby
      1   require 'rails_helper'
      2   
      3   feature 'My feature' do
      4     scenario 'is awesome' do
  >   5       visit '/users'
      6       expect(page).to have_content('Users')
      7       save_and_open_page
      8     end
      9   end
  
  ... etc., etc. ...
  

  I realize this may be "expected" behavior, but my question is, why is this happening?

[rossta]

I'm seeing the same issue and feel this should not be desired nor expected behavior; it makes this gem unusable for development. Also happens when using require: false in the Gemfile.

• better_errors-2.1.1
• rails-4.2.1
• rspec-core-3.2.1
• capybara-2.4.4
• ruby-2.2.2
• out-of-the-box config/test.rb

[rossta]

@mcmire I was able to workaround this issue by moving the web-console gem into the :test group only in my Gemfile. The default rails generator I used added web-console to the joint :development and :test group. Could it be the same for you?

[mcmire]

Hmm, I'm not sure. I'll have to take another look.

[ppdeassis]

+1

@rossta solution works for me. But since I'm using better_errors and binding_of_caller, I ended up removing web-console gem.

[edudepetris]

It works for me,

#config/environments/test.rb
config.action_dispatch.show_exceptions = true

extracted from https://forum.upcase.com/t/rspec-capybara-not-showing-rails-errors/1872/2

[RobinDaugherty]

Simply removing better_errors from the test group in the Gemfile seems to fix this completely.

group :development do
  gem 'better_errors'
  gem 'binding_of_caller'
end

Don't forget to remove (or comment out) the web-console gem in your Gemfile. I'm not aware of an advantage of having both in the same project, and there may be some conflicts between them.

This was with:

• better_errors 2.1.1
• rails 5.1.2
• rspec-core 3.6.0
• capybara 2.14.4
• ruby 2.4.0

(I tried both with and without binding_of_caller.)

[mcmire]

@RobinDaugherty Wow, this is an old issue :) So maybe it doesn't matter where better_errors is in the Gemfile -- it's more a matter of better_errors conflicting with web-console? Is that how you'd categorize this?

[RobinDaugherty]

A conflict with web-console seems the most likely cause, since moving it to the test group affected it. I suspect they changed something, but it may also be the newer version of Rails I used.