Skip to content

Conversation

@rzane
Copy link
Contributor

@rzane rzane commented Jan 22, 2025

Adding 3.4 is a bit more complicated, because no versions of Nokogiri support 3.0 and 3.4. We'd need separate gemfiles, ro we'd need to only test Ruby 3.4 against specific gemfiles.

@rzane rzane force-pushed the rzane/test-new-rubies branch from 3dd07b6 to 03e80d4 Compare January 22, 2025 14:49
@rzane rzane changed the title Add new Rubies to the CI matrix Add Ruby 3.3 to the CI matrix Jan 22, 2025
@rzane rzane force-pushed the rzane/test-new-rubies branch from 636bf3a to 85fea72 Compare January 22, 2025 14:55
@rzane rzane marked this pull request as ready for review January 22, 2025 15:01
@rzane rzane requested a review from smudge January 22, 2025 15:31
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge smudge merged commit 7e184ba into main Jan 22, 2025
53 checks passed
@smudge smudge deleted the rzane/test-new-rubies branch January 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants