Drop support for Rails 5.2 & Ruby 2.7 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-Betterment
force-pushed
the
drop_older_rails_support
branch
2 times, most recently
from
8cf72fe to
1cbc5ab
Compare
Irving-Betterment
changed the title
Irving-Betterment
force-pushed
the
drop_older_rails_support
branch
from
1cbc5ab to
ec62379
Compare
Irving-Betterment
requested review from
JELaVallee,
argvniyx-enroute and
rzane
Irving-Betterment
changed the title
| # frozen_string_literal: true | ||
|
|
||
| module Delayed | ||
| VERSION = '1.0.0' |
There was a problem hiding this comment.
I think we still stick to a minor bump when dropping a ruby version. See this webvalve commit, for example. Its parent is a commit dropping older ruby and rails versions.
Contributor
Author
There was a problem hiding this comment.
I second on being the preferred approach (so far). However, this internal conversation brought the necessity for a major version cut. cc @smudge
There was a problem hiding this comment.
Ah, I see, I wasn't aware of that convo.
Contributor
Author
There was a problem hiding this comment.
Follow-up: The updated consensus is to keep cutting minors for dependency drops.
Contributor
Author
|
@smudge can you please help me merging this approved PR? |
Irving-Betterment
dismissed stale reviews from smudge and argvniyx-enroute
via
c24c383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
This pull request drops support for the oldest Rails and Ruby versions, in order to streamline the supportability bracket. By doing so, It also cuts a minor version release.