fix: avoid eager DB connection when loading Journaled::Outbox::Event#71
Merged
fix: avoid eager DB connection when loading Journaled::Outbox::Event#71
Conversation
effron
reviewed
Apr 20, 2026
Comment on lines
+7
to
+9
| it 'uses a concrete type object so the class can be loaded without a database connection' do | ||
| expect(described_class.attribute_types['event_data']).to be_a(ActiveRecord::Type::Json) | ||
| end |
Contributor
There was a problem hiding this comment.
is it possible to directly test that db connection isn't required at class load time?
Member
Author
There was a problem hiding this comment.
I was finding it tricky to reproduce the load order issue within the gem's own spec, but lemme take another stab at this before I merge anything.
Passing a symbol to `attribute` (e.g. `attribute :event_data, :json`) causes Rails 7.2+ to call `ActiveRecord::Type.adapter_name_from` at class load time, which requires an active connection pool to resolve the adapter-specific type. This prevents the class from being autoloaded without a database connection (e.g. during tapioca gem shim generation). Replace with a concrete type object (`ActiveRecord::Type::Json.new`), which bypasses adapter resolution entirely and has identical behavior on PostgreSQL. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
betterment-policy-bot-production
Bot
dismissed
effron’s stale review
Invalidated by push of aa1f0d8
smudge
commented
Apr 20, 2026
Member
Author
There was a problem hiding this comment.
@effron I can confirm that this test reproduces the failure when I revert the changes to outbox/event.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Journaled::Outbox::Eventusesattribute :event_data, :jsonin its class body. In Rails 7.2+, passing a symbol toattributetriggersActiveRecord::Type.adapter_name_from(klass)→klass.connection_db_configat class load time, requiring an active connection pool to resolve the adapter-specific type implementation.This prevents the class from being loaded without a database connection — for example, during
tapioca gemsshim generation, where tooling tries to eager-load autoloaded constants to discover their shapes.Fix
Replace the symbol with a concrete type object:
ActiveRecord::Type::Jsonis a portable base type (available since Rails 5.2) that serializes/deserializes JSON without needing to know the adapter. Behavior on PostgreSQL is identical.Test plan
attribute_types['event_data']is anActiveRecord::Type::Jsoninstance, serving as a regression guard against re-introducing symbol-based type resolution/no-platform
🤖 Generated with Claude Code