[refactor][client] Remove duplicated and unused code in ACK grouping tracker #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracker ### Motivation There are a lot of duplicated code in PersistentAcknowledgmentsGroupingTracker caused by the check for whether the ACK receipt is supported. The only difference is that the read write lock will be used and then `currentIndividualAckFuture` or `currentCumulativeAckFuture` will be returned. In addition, the `validationError` argument in `newMessageAckCommandAndWrite` is never used. ### Modifications Move the `isAckReceiptEnabled` into `ConsumerImpl` and add two methods `acquireReadLock`/`acquireWriteLock` to acquire the read or write lock if ACK receipt is enabled. Remove the `validationError` argument.
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a lot of duplicated code in
PersistentAcknowledgmentsGroupingTracker caused by the check for whether the ACK receipt is supported. The only difference is that the read write lock will be used and then
currentIndividualAckFutureorcurrentCumulativeAckFuturewill be returned.In addition, the
validationErrorargument innewMessageAckCommandAndWriteis never used.Modifications
Move the
isAckReceiptEnabledintoConsumerImpland add two methodsacquireReadLock/acquireWriteLockto acquire the read or write lock if ACK receipt is enabled.Remove the
validationErrorargument.