Skip to content

Enabled tests for tsv scripts.#12

Merged
hrani merged 7 commits intostablefrom
enable_test
Dec 24, 2018
Merged

Enabled tests for tsv scripts.#12
hrani merged 7 commits intostablefrom
enable_test

Conversation

@dilawar
Copy link
Copy Markdown
Contributor

@dilawar dilawar commented Nov 19, 2018

Enabled tests in TestTsv folder.

Dilawar Singh added 3 commits November 19, 2018 20:26
@dilawar
Copy link
Copy Markdown
Contributor Author

dilawar commented Nov 23, 2018

A single tsv file was failing with python2 but not with python3. Changes have been made to matplotlib related code to make sure that this passes with warning.

Warning: displayPlot: Failed to plot ./TestTSV/dr_ratio_b2c.tsv due to "Data has no positive values, and therefore can not be log-scaled."

Rest of the tests passing normally locally.

@dilawar dilawar requested a review from upibhalla November 23, 2018 11:33
@dilawar
Copy link
Copy Markdown
Contributor Author

dilawar commented Nov 30, 2018

@upibhalla @nishaann @hrani Reminder for review. This PR integrates more tests with Travis CI.

@dilawar
Copy link
Copy Markdown
Contributor Author

dilawar commented Dec 18, 2018

@upibhalla @nishaann @hrani reminder on this PR.

@dilawar
Copy link
Copy Markdown
Contributor Author

dilawar commented Dec 24, 2018

@upibhalla @nishaann @hrani reminder.

@hrani
Copy link
Copy Markdown
Contributor

hrani commented Dec 24, 2018

ok

@hrani hrani assigned hrani and unassigned hrani Dec 24, 2018
@hrani hrani self-requested a review December 24, 2018 08:36
Copy link
Copy Markdown
Contributor

@hrani hrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hrani hrani merged commit 527d9bf into stable Dec 24, 2018
@dilawar dilawar deleted the enable_test branch December 26, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants