Windows port #373
Closed
Windows port #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moose.py is __init__.py _moose.so|pydis moose.so|pyd These changes are required for successful import on NT. Tests are passing. Not all but most.
dilawar
added a commit
to BhallaLab/moose-gui
that referenced
this pull request
Jun 28, 2019
`_moose` should not be imported directly. All functions gui needs should come from either `moose` or other python files. Never directly from cpp extenstion. `__init__.py` takes care that all functions are available under namespace moose. `_moose.so` might change to `_moose.so` if WIndows build PR (BhallaLab/moose-core#373) is merged.
Version is not PEP
All but 4 tests are passing.
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details on how to build on Windows are here https://github.com/BhallaLab/moose-core/wiki/Porting-to-Windows
Not tried yet.pymoose is ported to windows. It is building under MSYS2/Mingw-64. Once merged, we can upload windows compatible wheels to pypi. This PR is tested with
boostlibraries and not withgsl.Two functionality needs to be disabled. They can be enabled by using boost.
moose.SockerStreameris not built on windows.This should close BhallaLab/moose#176