Maintenance release 3.1.5 #382
Conversation
- cmake 3.12 is minimum required. - Fixes to Python API. strncpy can not write to `const char*`. Instead initialize with value. - Build system fixes.
need to change them everywhere.
|
|
||
| vec[currIndex].name = strdup(name.c_str()); | ||
| vec[currIndex].doc = (char*) "Destination field"; | ||
| // Dilawar: |
There was a problem hiding this comment.
@subhacom The clang++ compiler did not compile. Because PyGetSetDef.name is a const char* therefore the function strncpy can't write to this field. Have a look at these changes. I don't think there is a possibility of memory leak.
See https://docs.python.org/3/c-api/structures.html#c.PyGetSetDef
|
@upibhalla @hrani Please review and merge it into the After this PR is resolved, I can move on to address BhallaLab/homebrew-moose#1 |
|
@upibhalla @hrani reminder. |
…ld is being updated. These needs to be ported to branch chamcham as well.
|
Thanks @upibhalla . Please also create a tag the current |
|
Released 3.1.5, https://pypi.org/project/pymoose/ |
2 participants
World has moved on since moose 3.1.4 was released. This is a maintenance release.
python3is preferred over python2.Note for maintainers
v3.1.5. I can't do it since I am no longer on maintainer list for this repo.Once this PR is resolved, we can move on to fix BhallaLab/homebrew-moose#1