Merged
Conversation
syaau
reviewed
Aug 29, 2022
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "reliable-websocket", | |||
Contributor
There was a problem hiding this comment.
Can we have this named @bhoos/websocket
syaau
reviewed
Aug 29, 2022
| "name": "reliable-websocket", | ||
| "version": "0.0.0", | ||
| "description": "reliable websocket client", | ||
| "main": "dist/index.js", |
Contributor
There was a problem hiding this comment.
We want to go for es6 modules, so our typescript config should default to es6, and may be create a separate build for cjs.
{
"main": "dist/index.js",
"module": "es6/index.js",
"type": "module",
"react-native": "src/index.js"
}
syaau
reviewed
Aug 29, 2022
| }, | ||
| "dependencies": { | ||
| "ring-buffer-ts": "^1.0.3", | ||
| "ws": "^8.8.1" |
Contributor
There was a problem hiding this comment.
We will not depend on "ws" as it is not required on clients.
syaau
reviewed
Aug 30, 2022
Comment on lines
+1
to
+10
| import { CloseEvent, Event, ErrorEvent, MessageEvent } from 'ws'; | ||
| import { ReliableWS as WS } from './index.js'; | ||
|
|
||
| export declare class ReliableWS extends WS { | ||
| onopen: ((event: Event) => void) | null; | ||
| onerror: ((event: ErrorEvent) => void) | null; | ||
| onclose: ((event: CloseEvent) => void) | null; | ||
| onmessage: ((event: MessageEvent) => void) | null; | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
@bpanthi977 Aren't we able to get rid of this file now ?
Contributor
Author
There was a problem hiding this comment.
Yes we are.
Oversight from my part.
syaau
reviewed
Aug 30, 2022
syaau
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Checklist
Proposed Changes
A reliable dropin replacement for websocket.