Skip to content

Use 3 packages: @bhoos/websocket-base, @bhoos/websocket and @bhoos/websocket-node#7

Merged
syaau merged 6 commits intoBhoos:masterfrom
bpanthi977:master
Nov 4, 2022
Merged

Use 3 packages: @bhoos/websocket-base, @bhoos/websocket and @bhoos/websocket-node#7
syaau merged 6 commits intoBhoos:masterfrom
bpanthi977:master

Conversation

@bpanthi977
Copy link
Copy Markdown
Contributor

@bpanthi977 bpanthi977 commented Sep 16, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first. 
Any change needs to be discussed and documented before proceeding.
Mention which issue(s) are closed by this PR below. 
For e.g "Fixes #123 Fixes #12" in case of multiple fixes or include the issues under "Linked Issues"

Fixes #

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if necessary)
  • I have performed adequate tests that prove my fix is effective or that my feature works

Proposed Changes

  • add ondisconnect event which is fired when the connection disconnects/fails
  • use three packages: websocket/base, websocket/node, websocket

@syaau
Copy link
Copy Markdown
Contributor

syaau commented Sep 22, 2022

@bpanthi977 Can you change the publishConfig registry to https://npm.pkg.github.com

@syaau syaau merged commit 8be06e0 into Bhoos:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants