Add two missing cases in delMin BinomialHeaps.cpp#10
Merged
Bibeknam merged 1 commit intoBibeknam:masterfrom Dec 20, 2020
Merged
Add two missing cases in delMin BinomialHeaps.cpp#10Bibeknam merged 1 commit intoBibeknam:masterfrom
Bibeknam merged 1 commit intoBibeknam:masterfrom
Conversation
You missed two cases in deleteMin. when the minPtr has no sibling before or after i.e. there is only a single tree in the heap and when minPtr is the head of the heap and it has at least one sibling(i.e. there are multiple trees)
Srj
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You missed two cases in deleteMin.
when the minPtr has no sibling before or after i.e. there is only a single tree in the heap
and
when minPtr is the head of the heap and it has at least one sibling(i.e. there are multiple trees)