Skip to content

Bold the verse of the day in reader view#19

Merged
iwoithe merged 5 commits intoBibleNotify:masterfrom
tj330:dev
Jul 5, 2024
Merged

Bold the verse of the day in reader view#19
iwoithe merged 5 commits intoBibleNotify:masterfrom
tj330:dev

Conversation

@tj330
Copy link
Copy Markdown
Contributor

@tj330 tj330 commented Jul 2, 2024

Resolves: #5

@tj330 tj330 marked this pull request as ready for review July 2, 2024 03:56
@Correct-Syntax Correct-Syntax marked this pull request as draft July 2, 2024 04:02
@iwoithe iwoithe changed the title Modify notifications.py Bold the verse of the day in reader view Jul 2, 2024
Copy link
Copy Markdown
Member

@Correct-Syntax Correct-Syntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

Copy link
Copy Markdown
Member

@Correct-Syntax Correct-Syntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @tj330. Just a few more fixes. Once these are done, then I'll let @iwoithe review to see if he has any further comments.

@Correct-Syntax Correct-Syntax requested a review from iwoithe July 3, 2024 15:44
@Correct-Syntax Correct-Syntax marked this pull request as ready for review July 3, 2024 15:44
@Correct-Syntax
Copy link
Copy Markdown
Member

FYI @iwoithe I found a few bugs during testing of this PR. They are out-of-scope for this PR, so I'll open a new PR to address them once this one is merged.

Copy link
Copy Markdown
Member

@iwoithe iwoithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few last (minor) things to change!

Thanks!

Copy link
Copy Markdown
Member

@iwoithe iwoithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks again 😊

@iwoithe iwoithe merged commit e1018f3 into BibleNotify:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight verse in Reader

3 participants