Fix settings modal overflow and add scrolling#58
Merged
BigPizzaV3 merged 1 commit intoMay 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the injected Codex++ settings modal styling to prevent it from being clipped in shorter app windows by constraining the modal height and making the modal body independently scrollable.
Changes:
- Added a max-height constraint and switched the modal content container to a vertical flex layout with overflow hidden.
- Made the modal body scrollable (
overflow-y: auto) while keeping the header/tabs fixed, and added scrollbar styling. - Bumped
codexDeleteStyleVersion(and updated the corresponding renderer script test expectation) to ensure updated styles are re-injected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
codex_session_delete/inject/renderer-inject.js |
Updates injected modal CSS to constrain height and enable scrolling within the modal body; bumps style version for reinjection. |
tests/test_renderer_script.py |
Updates the assertion to match the new injected style version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm pleased to see so many features, but the settings page is currently too cluttered. It gets truncated by the Codex app window, so I'm requesting the installation of a scrollbar.
This change fixes the settings modal being clipped when the app window is not tall enough, and adds scrolling to the modal body so lower options remain reachable.
What changed
Scope
Validation
Verified:
node --check codex_session_delete/inject/renderer-inject.js./.venv/bin/python -m pytest tests/test_renderer_script.py -qNote:
tests/test_windows_installer.py::test_default_windows_launcher_uses_current_python_executableRisk
This is a small UI-only change focused on modal layout behavior. The main areas to watch are:
Expected result
Before:
After:
Screenshot