Skip to content

Fix settings modal overflow and add scrolling#58

Merged
BigPizzaV3 merged 1 commit into
BigPizzaV3:mainfrom
shallFun4Learning:fix/settings-modal-scroll
May 13, 2026
Merged

Fix settings modal overflow and add scrolling#58
BigPizzaV3 merged 1 commit into
BigPizzaV3:mainfrom
shallFun4Learning:fix/settings-modal-scroll

Conversation

@shallFun4Learning
Copy link
Copy Markdown
Contributor

Summary

I'm pleased to see so many features, but the settings page is currently too cluttered. It gets truncated by the Codex app window, so I'm requesting the installation of a scrollbar.

This change fixes the settings modal being clipped when the app window is not tall enough, and adds scrolling to the modal body so lower options remain reachable.

image

What changed

  • Added a max height constraint to the settings modal
  • Switched the modal to a vertical flex layout
  • Kept the header and tabs fixed while making the body independently scrollable
  • Added a vertical scrollbar for the modal body
  • Reduced vertical spacing between setting rows to make the modal more compact
  • Updated the related renderer script test to match the new style version

Scope

  • Settings modal layout and styling
  • Renderer script test coverage for the injected UI

Validation

Verified:

  • node --check codex_session_delete/inject/renderer-inject.js
  • ./.venv/bin/python -m pytest tests/test_renderer_script.py -q

Note:

  • The full test suite still has 1 pre-existing failure related to the Windows installer path assumption on macOS, which is outside the scope of this change:
    • tests/test_windows_installer.py::test_default_windows_launcher_uses_current_python_executable

Risk

This is a small UI-only change focused on modal layout behavior. The main areas to watch are:

  • Scroll behavior under different window heights
  • Scrollbar visibility in dark mode
  • Usability of the user-scripts panel with longer content

Expected result

Before:

  • The settings modal could extend beyond the visible app window and clip lower content

After:

  • The modal height stays within the available viewport
  • The modal body scrolls when content is too long
  • Lower settings remain accessible

Screenshot

fix

Copilot AI review requested due to automatic review settings May 12, 2026 16:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the injected Codex++ settings modal styling to prevent it from being clipped in shorter app windows by constraining the modal height and making the modal body independently scrollable.

Changes:

  • Added a max-height constraint and switched the modal content container to a vertical flex layout with overflow hidden.
  • Made the modal body scrollable (overflow-y: auto) while keeping the header/tabs fixed, and added scrollbar styling.
  • Bumped codexDeleteStyleVersion (and updated the corresponding renderer script test expectation) to ensure updated styles are re-injected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
codex_session_delete/inject/renderer-inject.js Updates injected modal CSS to constrain height and enable scrolling within the modal body; bumps style version for reinjection.
tests/test_renderer_script.py Updates the assertion to match the new injected style version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BigPizzaV3 BigPizzaV3 merged commit 6babab2 into BigPizzaV3:main May 13, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants