Conversation
- 상품 정보 수정 dto, controller, service 작성 - 컨트롤러, 서비스 테스트 코드 작성 - 이전에 작성한 API 변수명 정리
- 상품 삭제 controller, service 구현 완료 - 상품 삭제 컨트롤러, 서비스 테스트 코드 작성 완료 - 이전 서비스 코드 @transactional 추가
|
Jongdae519
reviewed
Jul 10, 2024
|
|
||
| private String itemImageDirectory = "item"; | ||
| public String itemImageDirectory = "item"; | ||
| public String defaultImageUrl = "https://billing-wise-bucket.s3.ap-northeast-2.amazonaws.com/test.png"; |
There was a problem hiding this comment.
이렇게 문자열을 지정할 때는 private static final로 선언하고 upper snake case로 작성하는 것을 추천드립니다.
url 주소니까 가장 좋은 것은 yml에 선언해서 불러오는 것이 좋아보이네요
Jongdae519
reviewed
Jul 10, 2024
| this.imageUrl = imageUrl; | ||
| } | ||
|
|
||
| public void setName(String name) { |
There was a problem hiding this comment.
set 메서드를 만들어야 한다면 field에 @Setter 선언하는 것도 고려해보면 좋을 것 같네요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
구현 기능
상품 정보 수정
상품 삭제
참고 사항