Lower allowableValues threshold to display multiSelect#256
Merged
bbimber merged 6 commits intodiscvr-23.11from Dec 19, 2023
Merged
Lower allowableValues threshold to display multiSelect#256bbimber merged 6 commits intodiscvr-23.11from
bbimber merged 6 commits intodiscvr-23.11from
Conversation
Contributor
Author
|
This should be merge-able. It'll enable multivalued select for any field with allowableValues. |
Contributor
|
@hextraza: the code seems fine, but I dont understand why the test failed on the postgres agents, but not sqlserver. this suggests maybe some timing/intermittent failure? I restarted that test to see if it repros. from the screenshot, the dropdown was empty for IMPACT, with zero options. maybe a timing issue? below is the stack: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This still needs rebasing + unit tests fixed, but it should allow all multivalued fields to use the multi select box.