Skip to content

Lower allowableValues threshold to display multiSelect#256

Merged
bbimber merged 6 commits intodiscvr-23.11from
23.11_fb_lowerMultivaluedThreshold
Dec 19, 2023
Merged

Lower allowableValues threshold to display multiSelect#256
bbimber merged 6 commits intodiscvr-23.11from
23.11_fb_lowerMultivaluedThreshold

Conversation

@hextraza
Copy link
Copy Markdown
Contributor

This still needs rebasing + unit tests fixed, but it should allow all multivalued fields to use the multi select box.

@hextraza hextraza marked this pull request as ready for review December 18, 2023 21:14
@hextraza hextraza requested a review from bbimber December 18, 2023 21:14
@hextraza
Copy link
Copy Markdown
Contributor Author

This should be merge-able. It'll enable multivalued select for any field with allowableValues.

@bbimber
Copy link
Copy Markdown
Contributor

bbimber commented Dec 19, 2023

@hextraza: the code seems fine, but I dont understand why the test failed on the postgres agents, but not sqlserver. this suggests maybe some timing/intermittent failure? I restarted that test to see if it repros. from the screenshot, the dropdown was empty for IMPACT, with zero options. maybe a timing issue?

image

below is the stack:

org.openqa.selenium.NoSuchElementException: Expected condition failed: waiting for xpath=//li[normalize-space()="HIGH"] (tried for 10 second(s) with 100 milliseconds interval)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:533)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:509)
  at app//org.labkey.test.Locator.waitForElement(Locator.java:502)
  at app//org.labkey.test.WebDriverWrapper.waitForElement_aroundBody10(WebDriverWrapper.java:2363)
  at app//org.labkey.test.WebDriverWrapper.waitForElement_aroundBody11$advice(WebDriverWrapper.java:40)
  at app//org.labkey.test.WebDriverWrapper.waitForElement(WebDriverWrapper.java:1)
  at app//org.labkey.test.WebDriverWrapper.waitForElement_aroundBody8(WebDriverWrapper.java:2358)
  at app//org.labkey.test.WebDriverWrapper.waitForElement_aroundBody9$advice(WebDriverWrapper.java:40)
  at app//org.labkey.test.WebDriverWrapper.waitForElement(WebDriverWrapper.java:1)
  at app//org.labkey.test.tests.external.labModules.JBrowseTest.testLuceneSearchUI(JBrowseTest.java:1717)
  at app//org.labkey.test.tests.external.labModules.JBrowseTest.testFullTextSearch(JBrowseTest.java:1153)
  at app//org.labkey.test.tests.external.labModules.JBrowseTest.testSteps(JBrowseTest.java:111)
  at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
  at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@bbimber bbimber merged commit 652459f into discvr-23.11 Dec 19, 2023
@bbimber bbimber deleted the 23.11_fb_lowerMultivaluedThreshold branch December 19, 2023 22:57
bbimber added a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants