Merged
Conversation
I wanted to do two solutions for this practice to see how verbosity changes readability. SwitchCase.java is the most verbose. I declared a method for each area calculation. I have separate inputs for each area parameter. In SwitchCaseTight.java I removed the extra methods and just simply pasted the one line mathematical calculation into the println statement. I also only removed a line by making the first input happen regardless of chosen area calculation. Looking at the two solution I feel that the more verbose one is easier to maintain in the long run. But I like how small the tight solution is. I think I will keep with the verbose solutions just because it is a better practice to make methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to do two solutions for this practice to see how verbosity changes readability.
SwitchCase.java is the most verbose. I declared a method for each area calculation. I have separate inputs for each area parameter.
In SwitchCaseTight.java I removed the extra methods and just simply pasted the one line mathematical calculation into the println statement. I also only removed a line by making the first input happen regardless of chosen area calculation.
Looking at the two solution I feel that the more verbose one is easier to maintain in the long run. But I like how small the tight solution is. I think I will keep with the verbose solutions just because it is a better practice to make methods.