Update Master Branch#140
Merged
asherpasha merged 25 commits intomasterfrom Jun 7, 2022
Merged
Conversation
Added Soybean SNP support (DB/endpoint python file/pytest)
… myself (Vincent): - fixed flake8 formatting syntax problems - Redid REST structure for endpoint (moved PDB to resource as a path param versus a query param) - Also no longer user parser() in endpoint, bug with updated flask complaining - Added rate limiter - Added limit to number of SNPs - Simplified and added commentary
Add /submit endpoint for final submission
Requirements updates
- Changed how error handling was parsed. Previously was parsing standard output and creating error messages. I have refactored to make it so the error message is directly created in pymol functions and then passed to be error 404'd. No more STDOUT/STDERR parsing - Added all the pymol functions to a class method for export (Asher's request). - Changed some URLs/Error messages to be more clear - Changed unit tests for pymol endpoint to not always run as pymol will not be installed by default in CI environment The pymol unit tests can still be run by pytest --key=
Added Yue Wei Wang's pymol endpoint code with some modifications from…
Code style.
Update keys for sending emails
Fixed ATTED service.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 83.10% 76.77% -6.34%
==========================================
Files 28 31 +3
Lines 1373 1623 +250
Branches 265 320 +55
==========================================
+ Hits 1141 1246 +105
- Misses 212 349 +137
- Partials 20 28 +8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.