Add missing C++ standard library includes#448
Open
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
Open
Add missing C++ standard library includes#448stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
Conversation
log_range_param.h and range_param.h rely on <cmath> being transitively included through other headers. Adding explicit includes ensures correct builds regardless of which headers are pulled in by dependencies.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added explicit
#include <cmath>tolog_range_param.handrange_param.h. These headers use symbols from<cmath>but relied on transitive includes, which can break with different compilers or standard library versions.Test plan