Open
Conversation
Migrate all TOML parsing from cpptoml to tomlplusplus. Introduce a TomlConfig typedef to insulate downstream code from the concrete library. Keep cpptoml in third_party/ with a deprecation pragma so existing includes still compile. Move BDM_ASSIGN_CONFIG_VALUE macros to a new toml_config.h and turn the old cpptoml.h utility header into a forwarding shim with a deprecation warning.
stanbot8
force-pushed
the
feat/replace-cpptoml-with-tomlplusplus
branch
from
3c06b3c to
a985450
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpptoml is unmaintained (last commit 2018) and only supports TOML v0.5. This replaces it with tomlplusplus v3.4.0, an actively maintained, header-only TOML v1.0 parser.
Changes
param.cc,param_group.cc,simulation.ccTomlConfigtypedef (using TomlConfig = toml::table) inparam_group.hso downstreamAssignFromConfigsignatures reference the typedef instead of the concrete library typecpptoml.hcompatibility wrapper so existingBDM_ASSIGN_CONFIG_VALUEmacros continue to workThe
TomlConfigtypedef means downstream simulations can use the full tomlplusplus API (e.g.config.at_path(), dotted keys, TOML v1.0 features) without coupling to a specific library. This enables cleaner config handling in projects like my skin simulation that use modular multi-file TOML configs.Test plan