feat: add test case for issue 50 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Stadick <sstadick@gmail.com>
sstadick
force-pushed
the
issue-50
branch
5 times, most recently
from
e6bc72d to
d8e9f43
Compare
sstadick
commented
Jun 23, 2025
Signed-off-by: Seth Stadick <sstadick@gmail.com>
It very much seems like there is a compiler bug optimizing the inner loop of profile creation with AVX512. When I use a `keep` around the vars to index in, it works, but without them it doesn't. The assembly generated between them also offers a hint: https://mojo.compiler-explorer.com/z/EzcxfxqnM AI looking at the assembly diff seems to think that it's possible that the vecotrized version is using a stack temp variable and writing outside that at some point. This is further enforced when running with GDB: ``` pixi run gdb --batch --ex run --ex bt --ex quit --args mojo run -I . tests/test_searcher.mojo ``` where it shows a segfault:o ``` Thread 1 "mojo" received signal SIGSEGV, Segmentation fault. 0x00007fff88037d9d in ?? () ``` However, I haven't been able to get a mimial example to reproduce outside the full codebase. Signed-off-by: Seth Stadick <sstadick@gmail.com>
Contributor
Author
|
Fixes #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.