Prepare LabProtocol and LabProcess for Release#719
Prepare LabProtocol and LabProcess for Release#719gtsueng merged 10 commits intoBioSchemas:masterfrom
Conversation
* Removed validation from Draft Type (no JSON schema validation rules needed for types) * Changed inheritance so that the file does not inherit from itself when it is merged * Updated to the file include the properties that would have been inherited from the previous version (which would be lost when it gets merged and behaves as a replacement rather than an addendum)
Added very basic JSON-schema validation rules for the 'parameter' property.
Added basic json-schema validation rules
gtsueng
left a comment
There was a problem hiding this comment.
The files look good to me from a technical perspective (from a formatting perspective).
From a schema perspective:
- One thing to note is that LabProcess uses 'instrument' (inherited from Action), while LabProtocol has 'labEquipment' instead. It would be good to harmonize this property between the two. Note that Sample/BioSample also use 'instrument', so I would recommend replacing 'labEquipment' with 'instrument'.
Regarding the automated conversion to bioschemas webpages:
- The conversion does NOT work on types. Types must be manually generated.
- You have to create the page manually for the bioschemas.github.io repository
@HLWeil @floWetzels -- please confirm whether or not there is any intention to harmonize the 'instrument' and 'labEquipment' property before the this draft is merged, or if the intention is to seek community input on the matter using this draft.
|
Thanks for your input, @gtsueng! We do currently make use of the |
@HLWeil Does the LabProcess/LabProtocol working group prefer to merge it as is before community input, or to change it before merging it and sending it out for community input? Lastly, is there a reason why the "@type" in the examples is an array? |
|
Also thanks from my side, @gtsueng! |
|
Regarding the |
--Thanks for the clarification, @floWetzels! Let's proceed as is then. Regarding the array of "@types" in the examples, I was just curious since I'd never seen it before. |
|
@albangaignard it looks like the tokens used in Sahar's script profile generation script expired. Can you fix/refresh it? |
Internal reference
Changes towards #715
Description
We substantially softened requirements of the
LabProtocolprofile and added a new propertyparameterto the type. We also added a profile forLabProcess.Motivation and context
We are making use of both the LabProcess and LabProtocol types extensively in the context of our ISA-RO-Crate-Profile and the ARC in RO-Crate. Here we identified the issue of too strict and extensive profiles, which are helpful in the context of a given community but can hinder interoperability between communities as the requirements vary. In our case, we softened the requirements of the LabProtocol profile to make it alignable with the Protocol class in ISA.
We would also like to advance the stable release of these types to make them more available (#715).
Have these been tested?
We have been using LabProcess and this less strict version of LabProtocol extensively in the context of our ISA-RO-Crate-Profile and the ARC.
What should reviewers focus on?
It would be great to get feedback on whether the changes are technically sound.
Types of changes
LabProtocol1.0_Drafttype (new version)parameterproperty (following the official guide)LabProtocol1.0_Draftprofile (new version)LabProcess0.1_Draftprofile (from scratch, following the official guide)LabProcess0.1_Draftexamples (new version)Future TO-DOs
LabProcessmissing from machine readable files #706)LabProtocolandLabProcessparameter,parameterValue, andexecutesProtocolas bioschemas properties