fix(change opts): fix the ability to change opts of current tomlua#80
Merged
Conversation
before the only way to get one with new settings was to copy a new one via the function call local newtomlua = tomlua(newopts) syntax. This was not intentional, but a consequence of the fact that, if a value was already in a table, __newindex is never called to tell our C representation that something changed. This means we can no longer mirror the opts into the lua table, the table is now purely a proxy table for the opts. In exchange, we can actually change them. This means you can now `tomlua.opts.some_opt = true` at runtime, as was the original intention To get the table, you can now call tomlua.opts() with no arguments and it will return it to you as a lua table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before the only way to get one with new settings was to copy a new one via the function call local newtomlua = tomlua(newopts) syntax.
This was not intentional, but a consequence of the fact that, if a value was already in a table, __newindex is never called to tell our C representation that something changed.
This means we can no longer mirror the opts into the lua table, the table is now purely a proxy table for the opts. In exchange, we can actually change them.
This means you can now
tomlua.opts.some_opt = trueat runtime, as was the original intentionTo get the table, you can now call tomlua.opts() with no arguments and it will return it to you as a lua table.