Skip to content

Bugfixes and code optimization#150

Merged
saberhq merged 8 commits intoBirolLab:masterfrom
kmnip:master
Jan 31, 2022
Merged

Bugfixes and code optimization#150
saberhq merged 8 commits intoBirolLab:masterfrom
kmnip:master

Conversation

@kmnip
Copy link
Collaborator

@kmnip kmnip commented Jan 26, 2022

  • add missing package names (fixes requirements.txt is incomplete #135)
  • create BAM instead of SAM in transcriptome mode (undo changes in 3d046e3)
  • set default file compression level to 1 (previously level 6)
  • optimize code for head/tail length calculation in transcriptome mode
  • optimize code for quantification

@kmnip kmnip requested a review from saberhq January 26, 2022 22:28
@kmnip kmnip self-assigned this Jan 26, 2022
saberhq
saberhq reviewed Jan 31, 2022
View reviewed changes
saberhq
saberhq approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@saberhq saberhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @kmnip . I tested all suggested edits and everything works good. I will merge the pull request.

saberhq
saberhq reviewed Jan 31, 2022
View reviewed changes
@saberhq saberhq merged commit ff052d5 into BirolLab:master Jan 31, 2022
@saberhq saberhq mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saberhq saberhq saberhq approved these changes

Assignees

@kmnip kmnip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

requirements.txt is incomplete

2 participants

@kmnip @saberhq