fix read headers in metagenome simulation#167
Merged
kmnip merged 1 commit intoBirolLab:masterfrom Jun 28, 2022
Merged
Conversation
Collaborator
|
Good catch! |
Collaborator
|
@saberhq , I tested the code in a test simulation and the read name looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When running metagenome simulations while outputting fastq files, with the most recent version of NanoSim 3.1, I found that read headers are empty (consisting only of the initial
@but no other information). It seems like right before finalization of a read, the header is set to the empty string once again. This PR fixes this.I have attached a directory (test_case_nanosim.tar.gz) containing all required files for building a docker container which replicates the issue, and demonstrates the fix described in this PR, which can be built and executed by running
docker build ..