Skip to content

Change single character keys in snakemake parameter configs to multi-character#27

Merged
lcoombe merged 7 commits intomainfrom
snakemake_fix
Sep 20, 2024
Merged

Change single character keys in snakemake parameter configs to multi-character#27
lcoombe merged 7 commits intomainfrom
snakemake_fix

Conversation

@lcoombe
Copy link
Copy Markdown
Contributor

@lcoombe lcoombe commented Sep 20, 2024

  • For snakemake v8.17.0+, there is an outstanding issue where it will not correctly parse single-character config parameters
  • To avoid errors, change single character config parameters in ntroot_run_pipeline.smk to multi-character strings
    • This is under the hood, and does not change the invocation of ntroot for users
  • In azure-pipelines.yml, temporarily build ntEdit from source
    • Needed for CI to pass until new ntEdit version is updated in bioconda

@lcoombe lcoombe requested a review from warrenlr September 20, 2024 20:13
Copy link
Copy Markdown
Contributor

@warrenlr warrenlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @lcoombe !

@lcoombe lcoombe merged commit 40f87a3 into main Sep 20, 2024
@lcoombe lcoombe deleted the snakemake_fix branch September 20, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants