Skip to content

Fix: Implement a fix for displaying non-freezed placeholders internally or with PAPI#12

Merged
CroaBeast merged 2 commits intomasterfrom
klema/fix-placeholders
Mar 8, 2026
Merged

Fix: Implement a fix for displaying non-freezed placeholders internally or with PAPI#12
CroaBeast merged 2 commits intomasterfrom
klema/fix-placeholders

Conversation

@Klema4
Copy link
Copy Markdown
Contributor

@Klema4 Klema4 commented Mar 6, 2026

This pull request introduces improvements to user loading logic, enhances PlaceholderAPI support for experience-related placeholders, and refines leaderboard status handling. The changes aim to make user state transitions more robust, provide more flexible placeholder options, and improve clarity in leaderboard display.

User loading and state management:

  • Refactored the user loading process in UserManagerImpl.java to ensure that offline users are properly converted to online users using the new toOnlineUser method, reducing code duplication and improving clarity. [1] [2]

PlaceholderAPI enhancements:

  • Added support for additional experience-related placeholders (e.g., experience_minimum, player_experience, player_experience_required, etc.) in PlaceholderAPI.java, making the API more flexible and consistent for plugin users. [1] [2]

Leaderboard display improvements:

  • Updated leaderboard placeholder logic to show a loading name when the leaderboard is updating, rather than always showing a no-player name, improving user feedback during leaderboard updates.

Listener registration cleanup:

  • Removed a redundant call to register() within the piston retract event handler in Listeners.java, preventing unnecessary registration logic.…; enhance PlaceholderAPI with additional experience-related identifiers; remove unused register call in Listeners.

…; enhance PlaceholderAPI with additional experience-related identifiers; remove unused register call in Listeners.
@Klema4 Klema4 requested a review from CroaBeast March 6, 2026 14:16
@Klema4 Klema4 self-assigned this Mar 6, 2026
@CroaBeast CroaBeast merged commit ce27c2c into master Mar 8, 2026
@CroaBeast CroaBeast deleted the klema/fix-placeholders branch March 8, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants