fix: remove early CLV 1.2.0 features#26
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes CLV 1.2.0 features (H2 database, AxBoosters/AxHoes/AxPickaxes hooks) from the 1.1.6 release line. The diff is clean and consistent: deleted H2 database class and dependency, removed all three Ax* hook classes and their plugin dependencies, stripped out the external multiplier logic, and cleaned up config/plugin.yml. No concerns with the changes — they align with the stated goal of keeping 1.2.0 work out of 1.1.6.
Changes:
- Removed H2 database backend (DatabaseFactory.H2 class, h2 dependency, h2 config field)
- Removed AxBoosters, AxHoes, and AxPickaxes hooks and their dependencies
- Removed external multiplier logic in HookManager and BaseSystem.getMultiplier()
- Cleaned up plugin.yml softdepend and libraries sections
- Removed axhoes-breaking and axpick-breaking earn-exp sources
Reviewed changes
- Low
src/main/java/com/bitaspire/cyberlevels/cache/Config.java- Database type default comment may be stale
The fallback default for database type in Config.java still references MYSQL but the description says it falls back to file storage. This is cosmetic but worth verifying the behavior is correct after removing H2.
Reviewed 15 changed files in this pull request and generated 1 inline comment.
Generated by pull_request.opened.
| base *= system.main.hookManager.externalMultiplier(getPlayer()); | ||
|
|
||
| return base; | ||
| return multiplier == 0 ? 1 : multiplier; |
There was a problem hiding this comment.
This change removes the external multiplier entirely. Confirm that getMultiplier() in BaseSystem no longer needs the system.main.hookManager reference, and that no other code path depends on externalMultiplier().
| return multiplier == 0 ? 1 : multiplier; | |
| return multiplier == 0 ? 1 : multiplier; |
Summary
Commits
Need help on this PR? Tag
@codesmithwith what you need.