Skip to content

fix: remove early CLV 1.2.0 features#26

Merged
Klema4 merged 1 commit into
masterfrom
codex/clv-116-remove-early-120
May 11, 2026
Merged

fix: remove early CLV 1.2.0 features#26
Klema4 merged 1 commit into
masterfrom
codex/clv-116-remove-early-120

Conversation

@CroaBeast
Copy link
Copy Markdown
Collaborator

@CroaBeast CroaBeast commented May 11, 2026

Summary

  • remove H2 database backend from CLV 1.1.6
  • remove AxBoosters, AxHoes and AxPickaxes hooks from CLV 1.1.6
  • keep 1.2.0 feature work out of the 1.1.6 release line

Commits

  • fix: remove early CLV 1.2.0 features

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Copy link
Copy Markdown

@review-me-code review-me-code Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes CLV 1.2.0 features (H2 database, AxBoosters/AxHoes/AxPickaxes hooks) from the 1.1.6 release line. The diff is clean and consistent: deleted H2 database class and dependency, removed all three Ax* hook classes and their plugin dependencies, stripped out the external multiplier logic, and cleaned up config/plugin.yml. No concerns with the changes — they align with the stated goal of keeping 1.2.0 work out of 1.1.6.

Changes:

  • Removed H2 database backend (DatabaseFactory.H2 class, h2 dependency, h2 config field)
  • Removed AxBoosters, AxHoes, and AxPickaxes hooks and their dependencies
  • Removed external multiplier logic in HookManager and BaseSystem.getMultiplier()
  • Cleaned up plugin.yml softdepend and libraries sections
  • Removed axhoes-breaking and axpick-breaking earn-exp sources

Reviewed changes

  • Low src/main/java/com/bitaspire/cyberlevels/cache/Config.java - Database type default comment may be stale
    The fallback default for database type in Config.java still references MYSQL but the description says it falls back to file storage. This is cosmetic but worth verifying the behavior is correct after removing H2.

Reviewed 15 changed files in this pull request and generated 1 inline comment.


Generated by pull_request.opened.

base *= system.main.hookManager.externalMultiplier(getPlayer());

return base;
return multiplier == 0 ? 1 : multiplier;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the external multiplier entirely. Confirm that getMultiplier() in BaseSystem no longer needs the system.main.hookManager reference, and that no other code path depends on externalMultiplier().

Suggested change
return multiplier == 0 ? 1 : multiplier;
return multiplier == 0 ? 1 : multiplier;

@Klema4 Klema4 merged commit eb80e9f into master May 11, 2026
1 check passed
@CroaBeast CroaBeast deleted the codex/clv-116-remove-early-120 branch May 11, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants