-
Notifications
You must be signed in to change notification settings - Fork 354
Add total earned #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total earned #114
Conversation
|
Very useful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Reviewed code, have not tested] Your commit overwrites two recently merged commits, #108 and #107
Please update code with these commits included. You can do what ever works.
Otherwise, I feel like this feature is a good enhancement. I will be glad to merge this once the issues are fixed and it has been user tested.
|
Need to rebase on master. |
|
Ok, i found a problem with poloniex API. This api return only 188 last loan but i when found solution i will make another pull to your review. Thanks Bruno Colombini'' Developer para iphone e sistemas Web.
|
|
@bcolombini , I make some tests. I think that I found something that may help you. but you most test it. on lendingbot.py on poloniex.py |
|
This functionality would be extremely useful to the bot, especially if it could list lifetime earnings by the bot, as well as broken down by monthly revenue. I have a spreadsheet where I manually run the report by comparing the Unix timestamps between two dates ala: But to have this automatically maintained in realtime by the bot would be awesome. I'd be willing to tip for this feature! |
|
@praeluceo I could do this, please contact me :) For my reference: https://poloniex.com/tradeHistory#analysis/BTC/-/lending |
| parser.add_argument("-spread", "--spreadlend", help="How many orders to split your lending into") | ||
| parser.add_argument("-gapbot", "--gapbottom", help="Percentage of your order's volume into the ledger you start lending") | ||
| parser.add_argument("-gaptop", "--gaptop", help="Percentage of your order's volume into the ledger you stop lending") | ||
| parser.add_argument("-60day", "--sixtydaythreshold", help="Rate at where bot will request to lend for 60 days") # only used for backward compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these arguments is what needs to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a complete refresh at this point.
|
I think this needs a rewrite. |
|
FYI, I'm working on an implementation for this with another approach. |
Add total earned by currency, and creating function in poloniex class.