Переверстал страницу настроек, добавил выбор страницы при запуске #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namxobick
reviewed
Oct 2, 2024
| builder: (p0) => const CommentsPage(), | ||
| isDisabled: false, | ||
| userTypes: [StudentData, EmployeeData], | ||
| userTypes: [StudentData, EmployeeData, UserData], |
Member
There was a problem hiding this comment.
мб просто тогда оставить UserData? Или ты пока оставил StudentData и EmployeeData с надеждой, что в какой-то момент мы начнём обрабатывать все типы пользователей =)
Contributor
Author
There was a problem hiding this comment.
У нас нет рефлексии и там идёт сравнение через ==
Я не уверен на 100%, но мне кажется, при таком сравнении будет StudentData != UserData и ни у кого роут не отобразится
Contributor
Author
There was a problem hiding this comment.
да, всё как я описал
Namxobick
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #391