#260: Reveal Votes

[cddjr]

closes #260

[v0idp]

I see you took that function I mentioned in the issue. Is this finished or still WIP ?

[cddjr]

I see you took that function I mentioned in the issue. Is this finished or still WIP ?

I have finished.

[DarkPenguin24]

There is one issue with this logic:
If someone votes while RevealVotes is disabled and u enable it at a later point u won't see the votes that were made already and they will also not appear at the end of the meeting which leads into false behaviour (e.g. only 2 people voting on person A which gets ejected while 4 people voted on person B).

[v0idp]

There is one issue with this logic: If someone votes while RevealVotes is disabled and u enable it at a later point u won't see the votes that were made already and they will also not appear at the end of the meeting which leads into false behaviour (e.g. only 2 people voting on person A which gets ejected while 4 people voted on person B).

maybe adding a second check on the hooked blipvote function and if that person didn't vote yet execute the original function

[DarkPenguin24]

this will fix it for "end of meeting". would prefer to fix it in a way it is always visible or not (depending on the state of RevealVotes. Like it is for the roles.

[v0idp]

wouldn't that mean that if it's disabled it wouldn't show at all anymore ? that's what I get from what you're saying. or do you mean also remove the previously drawn ones ?

[puscher]

Ideally:
Enabled -> show all votes that were made and all votes that will come in
Disabled -> show nothing at all (remove already drawn icons)

Same behaviour as we have for Roles:
Enabled -> shown
Disabled -> not shown at all (except of Red if you are imposter)

[cddjr]

Ideally: Enabled -> show all votes that were made and all votes that will come in Disabled -> show nothing at all (remove already drawn icons)

Same behaviour as we have for Roles: Enabled -> shown Disabled -> not shown at all (except of Red if you are imposter)

I have changed the code, please review.