feat(ada): add support for withdrawals from receive addr #5002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivpippal
force-pushed
the
WIN-3537-ADA-receiveAddr-Withdrawal-support
branch
from
088fd6a to
fca8133
Compare
OttoAllmendinger
requested changes
Oct 8, 2024
shivpippal
force-pushed
the
WIN-3537-ADA-receiveAddr-Withdrawal-support
branch
2 times, most recently
from
d7a8617 to
6a8d82d
Compare
shivpippal
force-pushed
the
WIN-3537-ADA-receiveAddr-Withdrawal-support
branch
from
6a8d82d to
ed90e7d
Compare
OttoAllmendinger
approved these changes
Oct 9, 2024
Comment on lines
+798
to
+800
| setCoinSpecificFieldsInIntent(intent: PopulatedIntent, params: PrebuildTransactionWithIntentOptions): void { | ||
| intent.unspents = params.unspents; | ||
| } |
Contributor
There was a problem hiding this comment.
just checking, ticket only says ADA; is this expected for SUI too ?
Contributor
Author
There was a problem hiding this comment.
I've just refactored it. Earlier, it was part of populateIntent function. WIN-3106
I've also updated the PR description
Vijay-Jagannathan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-3537 - Add support for witdrawals from receive addr
TICKET: WIN-3106 - Move coinSpecific flows from populateIntent() in mpcUtils.ts to appropriate coin files.