feat(wp): gpg encryption for passkey auth #5013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
WP-2733-gpg-passkey-encryption
branch
2 times, most recently
from
15834b0 to
e12f508
Compare
ghost
marked this pull request as ready for review
ghost
self-requested a review
ghost
force-pushed
the
WP-2733-gpg-passkey-encryption
branch
from
e12f508 to
3387cce
Compare
dpkjnr
reviewed
Oct 11, 2024
| assert.equal(e.message, 'Error decrypting message: Session key decryption failed.'); | ||
| } | ||
| }); | ||
| it('should not authenticate with wrong signing key', async () => { |
Contributor
There was a problem hiding this comment.
nit: add empty lines between tests, that looks more readable
dpkjnr
reviewed
Oct 11, 2024
| const keyPair = await generateGPGKeyPair('secp256k1'); | ||
| const encryptedToken = (await encryptAndSignText( | ||
| 'access_token', | ||
| keyPair.publicKey, |
Contributor
There was a problem hiding this comment.
rename the one of the keyPair object, it looks very confusing
pranavjain97
previously approved these changes
Oct 11, 2024
modules/sdk-api/src/bitgoAPI.ts
Outdated
Comment on lines
974
to
976
| if (!body.encryptedToken) { | ||
| throw new Error('encryptedToken is missing from response'); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!body.encryptedToken) { | |
| throw new Error('encryptedToken is missing from response'); | |
| } | |
| else if (body.encryptedToken) { | |
| ... | |
| } else { | |
| throw new Error('Failed to login. Please contact support@bitgo.com`) | |
| } |
add gpg decryption and signature verification to passkey authentication TICKET: WP-2733
ghost
force-pushed
the
WP-2733-gpg-passkey-encryption
branch
2 times, most recently
from
eebe859 to
2170204
Compare
add unit tests TICKET: WP-2733
ghost
force-pushed
the
WP-2733-gpg-passkey-encryption
branch
from
2170204 to
1eda08f
Compare
pranavjain97
approved these changes
Oct 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-2733