refactor(rune): address utility methods #5096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitkh7
force-pushed
the
coin-2191-rune-refactor
branch
from
617955b to
8d58f4a
Compare
zahin-mohammad
requested changes
Nov 5, 2024
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Update codeowners.
The wallets team should not be code owners for the coin modules.
bhavidhingra
previously approved these changes
Nov 5, 2024
mohitkh7
force-pushed
the
coin-2191-rune-refactor
branch
from
8d58f4a to
b53a9d1
Compare
Contributor
Author
@zahin-mohammad As requested, I have added code owners for the new |
at31416
approved these changes
Nov 5, 2024
zahin-mohammad
approved these changes
Nov 5, 2024
therealdwright
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-2191
Thorchain SDK requires address to be in Uint8Array format whereas Bitgo's WP and other services expects it to be in string format. This PR added few utility methods for address conversion and validation.