Skip to content

Conversation

@simhonc
Copy link
Contributor

@simhonc simhonc commented Nov 6, 2024

Description

Link to Jira: https://bitgoinc.atlassian.net/browse/WP-2971

This is to prevent the error "Unsupported public key" when trying to create an unsigned sweep for a TSS SMC wallet (eth-like), and to allow the user to go ahead with creating their unsigned transaction.

Type of change: Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

These SDK changes have been tested in wallet-recovery-wizard by modifying in node_modules. TODO: use the SDK beta version from this PR to test.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@simhonc simhonc force-pushed the wp-2971-handle-ecdsa-commonkeychain-tss-recovery branch 4 times, most recently from b4a6882 to 24af379 Compare November 7, 2024 15:05
@simhonc simhonc force-pushed the wp-2971-handle-ecdsa-commonkeychain-tss-recovery branch from 45b4f8e to ff8325f Compare November 7, 2024 17:40
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Jan 3, 2025

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants